Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any way to change the batch size? #84

Closed
yesbroc opened this issue Sep 1, 2023 · 2 comments
Closed

any way to change the batch size? #84

yesbroc opened this issue Sep 1, 2023 · 2 comments
Labels
enhancement New feature or request.

Comments

@yesbroc
Copy link

yesbroc commented Sep 1, 2023

running this on a comfyui backend on my pc, only thing i can change about the number of mages is the number of batches

(this could be a planned feature but i cant tell)

@mcmonkey4eva
Copy link
Contributor

Yes, I do have plans for batching that's a little fancier than just "add a param about it" (tldr, automatically determine batch size based on available resources, available backends, call rate, expected performance results, etc. such that you just generate as many images as you want and it automatically uses an ideal batch size without you ever having to worry about it).

That plan however is going to be delayed for a while as there's much higher priority things to do, so I've gone ahead and just added a simple batch size param, it's under the "Display Advanced Options" checkbox (imo 95% of users never have reason to touch this. It's technically a little bit faster to generate in batches, but usually not by much. You can get a better performance uplift by turning previews off lol).

Note that the seeds displayed in the UI from a comfy backend with batching will be wrong until this Comfy PR comfyanonymous/ComfyUI#1454 is merged.

@mcmonkey4eva
Copy link
Contributor

since comfy doesn't want to merge the seed fix i just went ahead and fixed it myself in swarm 8e21b9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants