Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests #11

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Run all tests #11

merged 2 commits into from
Jun 15, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Jun 1, 2024

Closes #10

@LecrisUT LecrisUT force-pushed the run-tests branch 3 times, most recently from c2af8f7 to 152a506 Compare June 1, 2024 20:19
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 1, 2024

Ack, now I know why the other tests were not running. We were using only the atuin crate, while the other tests that were failing were when running the whole workspace.

At least the postgres tests are working fine now.

@SriRamanujam
Copy link
Owner

Such a good find, nice job fixing this up :D

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 2, 2024

I will fix up this commit tomorrow so you can merge it while we figure out the remaining parts of the packaging PR. I think though upstream atuin might want a copr variant with vendored dependencies so maybe you could discuss sharing it there? Copr+packit should be able to generate artifacts for opensuse and various other targets.

LecrisUT and others added 2 commits June 10, 2024 15:35
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT marked this pull request as ready for review June 10, 2024 13:47
@LecrisUT
Copy link
Contributor Author

Took some time to fix the license part, but here you go

@SriRamanujam SriRamanujam merged commit a0b2443 into SriRamanujam:main Jun 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing postgres
2 participants