Add support for invite-notify #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://ircv3.net/specs/extensions/invite-notify Also remove the comments about IRCv3.1 / IRCv3.2, because IRCv3 does not classify its specs this way anymore.
SilverRainZ
requested changes
Apr 16, 2022
| chat = srn_server_add_and_get_chat(srv, origin); | ||
| g_return_if_fail(chat); | ||
| } | ||
|
|
There was a problem hiding this comment.
No need to "try get a SrnChat, otherwise add one", this is what srn_server_add_and_get_chat do.
There was a problem hiding this comment.
Not exactly. This code gets the channel chat if it already exists, and add/gets a chat with the origin otherwise
SilverRainZ
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ircv3.net/specs/extensions/invite-notify
Also remove the comments about IRCv3.1 / IRCv3.2, because IRCv3 does not
classify its specs this way anymore.
How to test:
Behavior is unchanged when being invited (ie. it still creates a private chat with the inviter)