Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll bar dragging state #62

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix scroll bar dragging state #62

merged 2 commits into from
Apr 22, 2024

Conversation

HaroldLever
Copy link
Contributor

Close #61

  • Remove _on_HScrollBar_scrolling() and _on_VScrollBar_scrolling().
  • Now scroll bar dragging logic is the same as content dragging.
  • any_scroll_bar_dragged() simply return h_scrollbar_dragging or v_scrollbar_dragging
  • Fix a mistake in update_state

@SpyrexDE
Copy link
Owner

I think you missed setting last_scroll_type = SCROLL_TYPE.BAR

@HaroldLever
Copy link
Contributor Author

Anything else I forgot?

@SpyrexDE SpyrexDE merged commit e5d17c8 into SpyrexDE:godot-4 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dragging scroll bar presents weird behavior
2 participants
@HaroldLever @SpyrexDE