✨ Improve JSON number parsing result #1158
Conversation
This improves json number parsing to distinguish between integers and floats. This allows checkers in the future to mark places were an integer is expected but a float is defined as incorrect. Also using bigint makes sure numbers are exact, which could in theory be relevant for range checks
| readonly type: 'json:number' | ||
| readonly value: number | ||
| readonly children: [core.LongNode | core.FloatNode] |
There was a problem hiding this comment.
Does this need to be a LongNode? Wouldn't IntegerNode be enough, because this is JSON?
There was a problem hiding this comment.
I used long node because it uses a bigint internally, so the parsed value can be more precise.
There was a problem hiding this comment.
That's what I mean. Does it need that precision? Aren't JSON values inherently restricted by the precision of JS numbers?
There was a problem hiding this comment.
I just figured there isn't any disadvantage of using a bigint. Not sure what the json spec says, and also not sure how Mojang handles this when codec specifies a long.
There was a problem hiding this comment.
Fair. I think bigints are a bit annoying in JS, for example if you have int @ 1..2 and you parse the 1..2 range as numbers but the json number itself is a bigint, you need to convert one to the other to compare them. Either way no major issues so I'm fine with it.
This examines the number at parse time to determine whether it is an integer or a float. This allows for better checking later on, when someone tries to define decimal places for a number that is defined as an integer.
Additionally, I simplified some of the other JSON parser definitions to use
core.setTypeinstead of doing that manually.