ci!: create full, default and slim artifacts #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add *-default builds * remove macos-rodio-* builds * slim and default linux builds use pulseaudio as audio backend
|
Hey @awerlang! Sorry that it took so long to check this PR out. Did you test it locally on a fork of spotifyd? Like publishing a dummy version and see if everything builds fine? 🤔 |
|
Hi! Yes, here's the test run: https://github.com/awerlang/spotifyd/runs/767314624?check_suite_focus=true I had a slightly different configuration (branch vs tag, and no release artifact). Two macos builds are reported as canceled, I don't recall why though. The macos-default build did complete. |
|
hm... Might have been a timeout. Thanks for answering that quickly though :) |
mainrs
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #589 (provides pulseaudio binaries, pipe support depends on #354)