Reimplemented timer using requestAnimationFrame
#45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
To fix #32, this PR implements the timer using the
requestAnimationFrame
API.Benefits
Notes
if there is more than a second of throttling, more than 1 second can be added at once to the timer.
Currently in the PR, the
timer-advanced
event is only fired once (essentially "skipping seconds" from the perspective of someone listening to the event).However, it can easily be implemented to fire an event for each passed seconds (all those events would fire at once).
Why
setTimeout
is not the way to go: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/setTimeoutCredits to #41 (comment) for the tip.