Tray icon animation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, great changes. Thank you. Seems like you picked up Vue just fine. I've tested this PR in Mac OS and there's an issue with the tray icon size and maximize functionality. OS has a different API for the tray, so I've disabled the option to minimize to tray unless Windows is being used. I've got a bit of work to do to merge this branch into master, but I'll update the app with these features soon. Nice work 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Contains changes from #26 as well, so please merge that one first)
This PR updates the tray icon dynamically while the timer runs. I wasn't sure exactly how to implement it as I haven't used Vue before, so this may not be the cleanest solution, although it kinda looks ok to me.