Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tester version conflict in scala 2.12 but not 2.11. #1229

Closed
Readon opened this issue Oct 30, 2023 · 12 comments
Closed

tester version conflict in scala 2.12 but not 2.11. #1229

Readon opened this issue Oct 30, 2023 · 12 comments

Comments

@Readon
Copy link
Collaborator

Readon commented Oct 30, 2023

I am trying on update the SpinalWorkshop and SpinalTemplateSbt to depends on spinal.tester only but import scalatest directly.
So I add below line into build.sbt

val spinalTester = "com.github.spinalhdl" %% "spinalhdl-tester" % spinalVersion % "test"

it works when I use scala 2.11 as default scala version.

However, when I switched scalaVersion to 2.12, the sbt test would report error that

(update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error]         * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over 1.0.6
[error]             +- org.scalatest:scalatest-core_2.12:3.2.14           (depends on 2.1.0)
[error]             +- org.scala-lang:scala-compiler:2.12.16              (depends on 1.0.6)

Where the "org.scala:scalatest-core_2.12:3.2.14" package is required by spinalhdl-tester for testing.
It means that package "org.scala:scalatest-core_2.11:3.2.14" do not have this constraints.

I have also checked that it seems that we need to depend on old package of scalatest to support scala 2.12.

@Readon
Copy link
Collaborator Author

Readon commented Oct 30, 2023

@andreasWallner @Dolu1990 have you met this while use scala 2.12?

@Readon
Copy link
Collaborator Author

Readon commented Oct 30, 2023

This does not appear in scala 2.13 also.

@andreasWallner
Copy link
Collaborator

Didn't see that before but it might be caused by the old scala 2.12 that we are depending on - did you try switching to the latest 2.12.18?

@Readon
Copy link
Collaborator Author

Readon commented Oct 30, 2023

Didn't see that before but it might be caused by the old scala 2.12 that we are depending on - did you try switching to the latest 2.12.18?

No, the version has to be changed first on SpinalHDL's repos. Or it will still depends on 2.12.13 which is now the building compiler of SpinalHDL itself.

@andreasWallner
Copy link
Collaborator

We did change the version of few days ago, not released yet though

@Dolu1990
Copy link
Member

to depends on spinal.tester

But spinal.tester isn't released, right ?
Did you localy released SpinalHDL tester, or integrated SpinalHDL code as a sbt module ?

I had much pain in general with the second option.

@Readon
Copy link
Collaborator Author

Readon commented Oct 30, 2023

to depends on spinal.tester

But spinal.tester isn't released, right ? Did you localy released SpinalHDL tester, or integrated SpinalHDL code as a sbt module ?

I had much pain in general with the second option.

it is released since 1.8.0. I suppose.

@Dolu1990
Copy link
Member

Ahhh right XD

I think we can release a new SpinalHDL version. Seems good to you ?

@Readon
Copy link
Collaborator Author

Readon commented Oct 31, 2023

Ahhh right XD

I think we can release a new SpinalHDL version. Seems good to you ?

It's ok, in new release the project can depends on spinal.tester only. so that no extra scalatest import is required.

@Dolu1990
Copy link
Member

Dolu1990 commented Nov 2, 2023

Just released 1.9.4

@Readon
Copy link
Collaborator Author

Readon commented Nov 2, 2023

i noticed that and just updated the msys-installer.

@Readon
Copy link
Collaborator Author

Readon commented Nov 4, 2023

It seems caused by scala 2.12.13, after upgrade to 2.12.18, it works. So the lib version below 1.9.3 would cause this error.

@Readon Readon closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants