Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A list-dropdown flash the hidden menu briefly #207

Closed
zemian opened this issue Aug 27, 2023 · 3 comments
Closed

A list-dropdown flash the hidden menu briefly #207

zemian opened this issue Aug 27, 2023 · 3 comments

Comments

@zemian
Copy link

zemian commented Aug 27, 2023

I am not sure if just me, or I see hidden part of dropdown list displayed briefly (flash) then it is hidden.

Create list-dropdown like this, and then simply hit F5 to refresh the page, I see the hidden menu getting flashed.


            <div class="list-dropdown">
                <div class="btn-group">
                    <button class="btn-primary">Dropdown</button>
                    <button class="btn-primary btn--sm btn-dropdown"><i class="fa fa-wrapper fa-caret-down" aria-hidden="true"></i>
                    </button>
                    <ul class="menu">
                        <li class="menu-item"><a href="!#">Google Chrome</a></li>
                        <li class="menu-item selected"><a href="!#">Firefox</a></li>
                        <li class="menu-item"><a href="!#">Polarity</a></li>
                    </ul>
                </div>
            </div>
@zemian
Copy link
Author

zemian commented Aug 27, 2023

BTW, why not name the class dropdown-list instead of list-dropdown? It sounds backward.

@Spiderpig86
Copy link
Owner

Will take a look since I can confirm this.

BTW, why not name the class dropdown-list instead of list-dropdown? It sounds backward.

It follows the convention of <element>-<sub property>. In this case, it follows the same way we name btn-primary. Both these preceded updates to follow a more BEM like naming convention like btn--sm.

@Spiderpig86
Copy link
Owner

Closing since this has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants