Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc example on flex-grow is incorrect #195

Closed
zemian opened this issue Aug 20, 2023 · 2 comments
Closed

Doc example on flex-grow is incorrect #195

zemian opened this issue Aug 20, 2023 · 2 comments

Comments

@zemian
Copy link

zemian commented Aug 20, 2023

In https://www.cirrus-ui.com/utils/flexbox#flex-grow there are two examples. The 2nd example code for u-flex-grow-0 seems to be incorrect.

What's in the doc does not produced on picture shows on the pink example:

<div class="u-flex u-gap-2 u-round-xs bg-blue-100 p-3 text-white font-bold u-text-center">
    <div class="u-round-xs u-shadow-lg bg-blue-300 p-2">0</div>
    <div class="u-round-xs u-shadow-lg bg-blue-500 p-2 u-flex-shrink-1 w-100p">1</div>
    <div class="u-round-xs u-shadow-lg bg-blue-300 p-2">0</div>
</div>

Perhaps it should be this instead:

<div class="u-flex u-gap-2 u-round-xs bg-pink-100 p-3 text-white font-bold u-text-center">
    <div class="u-round-xs u-shadow-lg bg-pink-300 p-2 u-flex-grow-1">0</div>
    <div class="u-round-xs u-shadow-lg bg-pink-500 p-2 u-flex-grow-0">1</div>
    <div class="u-round-xs u-shadow-lg bg-pink-300 p-2 u-flex-grow-1">0</div>
</div>
@Spiderpig86
Copy link
Owner

Good catch, look like there are some incorrect code examples there. I will update those accordingly.

@Spiderpig86
Copy link
Owner

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants