Audit Fixes: QS-17 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the tests are passing and all the checks are merged can we merge this with the base branch |
… into fix/usdt-force-approve
parv3213
changed the base branch from
fix/using-safeIncreaseAllowance
to
dev
YashP16
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safeApprovewithforceApprovein instances where we approve an amount to be utilized in the same transaction. AlthoughforceApproveprevents a Denial-of-Service (DOS) attack if some dust amount was left.forceApprovewithinsafeIncreaseAllowanceitself, which might be cleaner code for us. However, we cannot use this version as it is not compatible with older USDs upgrades.