Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter/compose sample #396

Merged
merged 19 commits into from
Jan 28, 2025
Merged

Chapter/compose sample #396

merged 19 commits into from
Jan 28, 2025

Conversation

kelianClerc
Copy link
Collaborator

Introduce compose space where to put composable that are matching Figma component file

Enregistrement.de.l.ecran.2025-01-17.a.17.38.08.mov

The categories have been created to match the ones in that file.
For instance:
I'm opening Messaging page.
I have Badge, Callout, EmptyState, Message, Tag and Toaster to add later
Capture d’écran 2025-01-17 à 17 39 05

@kelianClerc kelianClerc force-pushed the chapter/compose-sample branch from 6ce7d1b to 84d7eef Compare January 17, 2025 16:41
jpbarbaud
jpbarbaud previously approved these changes Jan 20, 2025
Copy link
Contributor

@jpbarbaud jpbarbaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read and approved :D

item(span = { GridItemSpan(maxLineSpan) }) {
GridHeader(text = "Design tokens")
}
item {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add item ids ?

@Composable
fun IconsDestination() {
LazyVerticalGrid(modifier = Modifier.fillMaxSize(), columns = GridCells.Fixed(4)) {
item {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for id ?

@kelianClerc kelianClerc force-pushed the chapter/compose-sample branch from 84d7eef to e104f29 Compare January 27, 2025 16:02
@kelianClerc kelianClerc merged commit 5c59abf into develop Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants