Task/migrate shape design tokens #311
Merged
+144
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainGF
reviewed
Dec 13, 2023
| val borderRadius1: CornerBasedShape = RoundedCornerShape(borderRadius1Dp), | ||
| val borderRadius2: CornerBasedShape = RoundedCornerShape(borderRadius2Dp), | ||
| val borderRadius3: CornerBasedShape = RoundedCornerShape(borderRadius3Dp), | ||
| val borderRadiusRounded: CornerBasedShape = RoundedCornerShape(borderRadiusRoundedPercent), |
There was a problem hiding this comment.
What about using CircleShape directly ? It's a RoundedCornerShape(50), because 100% seems strange as 50% is already a circle
kelianClerc
force-pushed
the
task/migrate-shape-design-tokens
branch
from
fa1a95d to
f1e585a
Compare
kelianClerc
force-pushed
the
task/migrate-shape-design-tokens
branch
from
f1e585a to
a5d39bc
Compare
RomainGF
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.