Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4663: Followup #776

Merged
merged 1 commit into from
Aug 6, 2024
Merged

BED-4663: Followup #776

merged 1 commit into from
Aug 6, 2024

Conversation

superlinkx
Copy link
Contributor

Description

Removes the logic to convert unknown AD nodes into AD User nodes when making hybrid edges

Motivation and Context

This PR addresses: BED-4663

We don't want to alter unknown nodes for consistency, so the logic was removed. Some test parameters needed to be adjusted to cover the change properly.

How Has This Been Tested?

Tests were altered to handle the correct logic and are passing

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

fix: update tests to account for this behavior
Copy link
Collaborator

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@superlinkx superlinkx merged commit 3319444 into stage/v5.13.1 Aug 6, 2024
3 checks passed
@superlinkx superlinkx deleted the BED-4663 branch August 6, 2024 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants