Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4666: remove logout on 401 /features #768

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

benwaples
Copy link
Contributor

@benwaples benwaples commented Aug 2, 2024

Description

Block logout attempts after a 401 when the requested url is /api/v2/features

Motivation and Context

This PR addresses: BED-4666

When a user is logging in with MFA, if the page is unfocused and then refocused, the /features endpoint will 401 and force the user back to the username/password screen.

How Has This Been Tested?

manual tests and added unit tests

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@benwaples benwaples added bug Something isn't working user interface A pull request containing changes affecting the UI code. labels Aug 2, 2024
@benwaples benwaples self-assigned this Aug 2, 2024
@benwaples benwaples marked this pull request as draft August 2, 2024 18:03
@benwaples benwaples changed the title fix: logout on 401 /features BED-4666: remove logout on 401 /features Aug 2, 2024
@benwaples benwaples marked this pull request as ready for review August 2, 2024 21:07
@benwaples benwaples merged commit b302b6e into stage/v5.13.1 Aug 2, 2024
3 checks passed
@benwaples benwaples deleted the BED-4666--401-features branch August 2, 2024 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants