Refactored unauthorized access audit logging: #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved audit logging responsibility to Authorizer interface - cleaned up injections of *db through several layers of code (no longer necessary) - minor cleanup and support work
sircodemane
commented
Feb 2, 2024
| @@ -85,50 +88,85 @@ func (s idResolver) GetIdentity(ctx Context) (SimpleIdentity, error) { | |||
| } | |||
| } | |||
|
|
|||
| type AuditLogger interface { | |||
| AppendAuditLog(ctx context.Context, entry model.AuditEntry) error | |||
There was a problem hiding this comment.
This was necessary because interfaces are good and import cycles are bad
sircodemane
commented
Feb 2, 2024
irshadaj
reviewed
Feb 2, 2024
irshadaj
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Just some cleanup
How Has This Been Tested?
unit and integration tests
Screenshots (if appropriate):
Types of changes
Checklist: