Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: esc6a edge composition #359

Merged
merged 4 commits into from
Jan 30, 2024
Merged

feat: esc6a edge composition #359

merged 4 commits into from
Jan 30, 2024

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Jan 29, 2024 •
edited
Loading

Description

This changeset enables viewing the ESC6a edge composition from the edge information pane.

Motivation and Context

The current 6a edge information pane does not have the composition accordion implemented.

How Has This Been Tested?

Integration tests have been updated to check for composition details.

Screenshots (if appropriate):

Screenshot 2024-01-29 at 10 57 09 AM

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

JonasBK
JonasBK requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@JonasBK JonasBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested

packages/go/analysis/ad/ad.go Outdated Show resolved Hide resolved
@urangel urangel enabled auto-merge (squash) January 30, 2024 15:11
@urangel urangel merged commit e43b0d3 into main Jan 30, 2024
3 checks passed
@urangel urangel deleted the BED-4002 branch January 30, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvazarkar rvazarkar rvazarkar approved these changes

@JonasBK JonasBK JonasBK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urangel @rvazarkar @JonasBK