Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stricter static analysis #355

Merged
merged 7 commits into from
Jan 31, 2024
Merged

fix: stricter static analysis #355

merged 7 commits into from
Jan 31, 2024

Conversation

superlinkx
Copy link
Contributor

@superlinkx superlinkx commented Jan 25, 2024 •
edited
Loading

Description

  • More SCA fixes and some additional warnings added
  • Adds better logging to our st-bernard analyze action to diagnose why it's sometimes failing in GitHub actions
  • Fixes one pattern that was leading to unhandled errors pretty consistently by making it not return an error

Motivation and Context

  • SCA hygiene improvements (first of many)
  • Figuring out why golangci-lint is failing with no valid JSON output

How Has This Been Tested?

Ran through all our existing tests. Analysis locally found no new issues after all fixes are in place.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@superlinkx superlinkx self-assigned this Jan 25, 2024
superlinkx
superlinkx commented Jan 25, 2024
View reviewed changes
.golangci.json Show resolved Hide resolved
.golangci.json Outdated Show resolved Hide resolved
.golangci.json Show resolved Hide resolved
@superlinkx superlinkx force-pushed the stricter-static-analysis-fixes branch from 3698410 to dada015 Compare January 31, 2024 21:25
superlinkx
superlinkx commented Jan 31, 2024
View reviewed changes
cmd/api/src/daemons/datapipe/jobs.go Show resolved Hide resolved
packages/go/analysis/ad/ad.go Show resolved Hide resolved
packages/go/analysis/ad/ad.go Show resolved Hide resolved
packages/go/analysis/azure/post.go Outdated Show resolved Hide resolved
packages/go/crypto/argon2.go Show resolved Hide resolved
packages/go/dawgs/drivers/pg/query/format.go Show resolved Hide resolved
packages/go/dawgs/drivers/pg/transaction.go Show resolved Hide resolved
packages/go/dawgs/query/neo4j/neo4j.go Show resolved Hide resolved
packages/go/dawgs/traversal/traversal.go Show resolved Hide resolved
packages/go/stbernard/analyzers/golang/golang.go Outdated Show resolved Hide resolved
@superlinkx superlinkx marked this pull request as ready for review January 31, 2024 21:53
zinic
zinic approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my comment regarding the PG codebase, please remove unused elements. Otherwise this is good to merge when passing.

@superlinkx superlinkx enabled auto-merge (squash) January 31, 2024 23:08
@superlinkx superlinkx merged commit 976227f into main Jan 31, 2024
3 checks passed
@superlinkx superlinkx deleted the stricter-static-analysis-fixes branch January 31, 2024 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zinic zinic zinic approved these changes

Assignees

@superlinkx superlinkx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superlinkx @zinic