Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter out ESC3 false positives #351

Merged
merged 11 commits into from
Jan 30, 2024
Merged

feat: filter out ESC3 false positives #351

merged 11 commits into from
Jan 30, 2024

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Jan 25, 2024

Description

Prevent creating ADCSESC3 edges from users if they cannot enroll due to CertTemplate requirement for DNS name.

Motivation and Context

We should stop creating ADCSESC3 edges from user nodes if the enrollment agent certificate template requires a DNS name, as users cannot enroll in such a cert template.

How Has This Been Tested?

Tested by uploading ESC3 data with and without the DNS requirement.
Also ran "just test -a".

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@JonasBK JonasBK enabled auto-merge (squash) January 30, 2024 10:09
@rvazarkar rvazarkar enabled auto-merge (squash) January 30, 2024 15:55
@rvazarkar rvazarkar merged commit 1be5827 into main Jan 30, 2024
3 checks passed
@rvazarkar rvazarkar deleted the BED-4060 branch January 30, 2024 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants