chore: remove unnecessary complexity in the data pipeline #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinic
force-pushed
the
datapipe-rework
branch
from
8262359
to
42b5b03
Compare
elikmiller
reviewed
Jan 25, 2024
zinic
force-pushed
the
datapipe-rework
branch
3 times, most recently
from
cb5ed23
to
6916687
Compare
zinic
force-pushed
the
datapipe-rework
branch
from
2d88101
to
cfcb29c
Compare
computator
reviewed
Jan 29, 2024
Comment on lines
+100
to
104
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| default: | ||
| } |
There was a problem hiding this comment.
This can be updated to use Ctx.Err() if you think it's worth the change:
if ctx.Err() != nil {
return
}| if s.cfg.DisableAnalysis { | ||
| return | ||
| } | ||
|
|
||
| s.status.Update(model.DatapipeStatusAnalyzing, false) | ||
| log.Measure(log.LevelInfo, "Starting analysis")() | ||
| log.LogAndMeasure(log.LevelInfo, "Graph Analysis")() |
There was a problem hiding this comment.
does this need to be deferred?
| if fileUploadJobsUnderAnalysis, err := s.db.GetFileUploadJobsWithStatus(model.JobStatusAnalyzing); err != nil { | ||
| return 0, err | ||
| } else { | ||
| numJobsWaitingForAnalysis += len(fileUploadJobsUnderAnalysis) |
There was a problem hiding this comment.
This looks like it could just be an assignment, although the increment is equivalent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset removes several unnecessary components of the data pipeline. The original intent for the in-memory retention of completed file upload jobs was to trigger analysis immediately upon completion of file-upload. However, addition of configuration for the loop ticker and a clearer path for triggering a data pipeline loop run removes the need for this complexity.
This also removes a gap where a timed out file upload job could have its status overwritten later on during analysis.
Motivation and Context
The data pipeline is already complex enough, as-is. Let's not make it harder on ourselves to maintain this part of the system.
How Has This Been Tested?
Updated unit tests.
Types of changes
Checklist: