fix: not ingesting tenant count during azure analysis #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistahj67
commented
Jan 19, 2024
| KeyVaults: 1, | ||
| Relationships: 188, | ||
| } | ||
| _, agg, err := azure2.GraphStats(context.TODO(), testCtx.GraphDB) |
There was a problem hiding this comment.
I opted to skip verifying the individual stats slice of structs here because building the expected result involves retrieving a runId which is generated inside of graphStats fn itself, as well as all the hardcode above x12. If anyone changes the harnesses, the agg will fail this test anyway. That said, I'm open to any solutions that might get us a less brittle test here.
| @@ -48,7 +48,7 @@ func GraphStats(ctx context.Context, db graph.Database) (model.AzureDataQualityS | |||
| runID = newUUID.String() | |||
| } | |||
|
|
|||
| return stats, aggregation, db.ReadTransaction(ctx, func(tx graph.Transaction) error { | |||
| err := db.ReadTransaction(ctx, func(tx graph.Transaction) error { | |||
There was a problem hiding this comment.
This change is just for readability.
mistahj67
force-pushed
the
BED-3858
branch
4 times, most recently
from
b3159ac
to
b6789d2
Compare
irshadaj
reviewed
Jan 25, 2024
irshadaj
reviewed
Jan 25, 2024
| @@ -1042,6 +1068,7 @@ type AZInboundControlHarness struct { | |||
|
|
|||
| func (s *AZInboundControlHarness) Setup(testCtx *GraphTestContext) { | |||
| tenantID := RandomObjectID(testCtx.testCtx) | |||
| s.Tenant = testCtx.NewAzureTenant(tenantID) | |||
There was a problem hiding this comment.
The JSON/SVGs will need to be updated here like we did for the other one above
irshadaj
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When selecting “All Azure Tenants” in Data Quality, the statistics table shows 0 (zero) tenants.
Motivation and Context
All Azure Tenants stats should accurately display tenant count.
How Has This Been Tested?
Integration test has been added.
Screenshots (if appropriate):
Types of changes
Checklist: