Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable_cypher_qc and other 3+ segment JSON keys #190

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

superlinkx
Copy link
Contributor

Description

Fixes a bug that caused config keys with more than one underscore to not be parsed.

Regression tests have been added to avoid further issues

Motivation and Context

The previous env var fixes introduced a bug when attempting to find the end of a key when the key contains multiple underscores

How Has This Been Tested?

Additional tests have been added and various configurations with varying numbers of underscores and path segments were reviewed to ensure we have coverage for variations of path sizes and variations of multiple underscores per key.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

The previous env var fixes introduced a bug when attempting to find the
end of a key when the key contains multiple underscores

Regression tests have been added to avoid further issues
@superlinkx superlinkx merged commit 69df0e6 into main Nov 9, 2023
2 checks passed
@superlinkx superlinkx deleted the env-var-fixes branch November 9, 2023 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants