Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Snakemake workflow update #206

Merged
merged 16 commits into from
Feb 27, 2024
Merged

(WIP) Snakemake workflow update #206

merged 16 commits into from
Feb 27, 2024

Conversation

Jieran-S
Copy link
Member

Update existing snakemake workflow to cope with repo update.

detailed progress at #205

open this PR for code check and update.

@Jieran-S Jieran-S linked an issue Feb 14, 2024 that may be closed by this pull request
@Jieran-S Jieran-S removed a link to an issue Feb 14, 2024
@Jieran-S Jieran-S linked an issue Feb 14, 2024 that may be closed by this pull request
@niklasmueboe
Copy link
Collaborator

I did have a look at the changes, but didn't test though. I assume everything is working?

Can you run snakefmt to clean up the code a bit before we merge?

@niklasmueboe
Copy link
Collaborator

There are quite a few files in there that probably shouldn't be part of this pull request e.g. changes to method implementations.

@Jieran-S
Copy link
Member Author

Hi, yes that's cuz I merged main to the wip_wf_optargs. I also merged main to wip_workflows: maybe those changes shouldn't matter? I can restart a new pr

@niklasmueboe
Copy link
Collaborator

Please only add workflow related changes to this PR, otherwise we might get a mess when trying to merge the workflow to main later.

method/bass/bass.r Outdated Show resolved Hide resolved
@niklasmueboe niklasmueboe merged commit c8eae0d into wip_workflows Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snakemake workflow
2 participants