Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast empty headers to int #3646

Merged

Conversation

ahmedash95
Copy link
Contributor

@ahmedash95 ahmedash95 commented Jun 4, 2022

Hello Patrick,

1️⃣ Why should it be added? What are the benefits of this change?
Fixes #3563. also, it makes handling empty headings to have unique value instead of having all as an empty string

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
Nope.

3️⃣ Does it include tests, if possible?
Yes

4️⃣ Any drawbacks? Possible breaking changes?
It might break existing projects if any rely on the empty value of the headings

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@ahmedash95 ahmedash95 force-pushed the cast_empty_headers_to_int branch from d148461 to f3ab030 Compare June 4, 2022 11:13
@patrickbrouwers patrickbrouwers merged commit 58b0e68 into SpartnerNL:3.1 Jun 5, 2022
@patrickbrouwers
Copy link
Member

Thanks!

@ahmedash95 ahmedash95 deleted the cast_empty_headers_to_int branch September 23, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected behavior when headers have null values using HeadingRowImport
2 participants