-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/WithGroupedHeadingRow #3575
Features/WithGroupedHeadingRow #3575
Conversation
…sing SkipsEmptyRows
Apply fixes from StyleCI
Thanks for the PR, looks good. Can you also update the changelog? |
Whoops, closed my previous PR to keep your package commit history as clean as possible and forgot to include the changelog again. |
Apply fixes from StyleCI
Apply fixes from StyleCI
@patrickbrouwers Should be good for further review now. I also made Maybe I should update the concern to |
That's a good idea, nice!
Yes, that sounds better, great suggestion! |
Apply fixes from StyleCI
…ee86daf7e' into features/with-grouped-headers""" This reverts commit 17b5237.
Apply fixes from StyleCI
…aravel-Excel into features/with-grouped-headers
Apply fixes from StyleCI
1️⃣ Why should it be added? What are the benefits of this change?
Adds concern
WithGroupedHeadingRow
to allow import sheets to group data values in an array when multiple columns share the same header key2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No
3️⃣ Does it include tests, if possible?
Yes
4️⃣ Any drawbacks? Possible breaking changes?
No
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌