Failing test for prepareForValidation not called with SkipsEmptyRows

[VFAndrew]

1️⃣ Why should it be added? What are the benefits of this change?
Failing test requested so bug may be fixed. #3324 (comment)

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests, if possible?
Yes

4️⃣ Any drawbacks? Possible breaking changes?
No

5️⃣ Mark the following tasks as done:

• [ x ] Checked the codebase to ensure that your feature doesn't already exist.
• [ x ] Take note of the contributing guidelines.
• [ x ] Checked the pull requests to ensure that another person hasn't already submitted a fix.
• [ x ] Added tests to ensure against regression.
• [ x ] Updated the changelog

6️⃣ Thanks for contributing! 🙌

[VFAndrew]

It appears the issue is with line 294 of Sheet.php.

if (!$import instanceof SkipsEmptyRows || ($import instanceof SkipsEmptyRows && !$sheetRow->isEmpty($calculatesFormulas)))

when it checks if the row is empty the row toArray() sets the row->rowCache then on line 298 when toArray() is called again for validation preparation.

$toValidate = [$sheetRow->getIndex() => $sheetRow->toArray(null, $import instanceof WithCalculatedFormulas, $import instanceof WithFormatData, $endColumn)];

the row toArray() checks for the rowCache and returns immediately on line 75 of Row.php without preparingForValidation on line 94

[VFAndrew]

In my opinion the best solution would be to set the preparationCallback on the sheetRow before the empty row is checked for on line 294

I have a branch I can PR if desired. https://github.com/VFAndrew/Laravel-Excel/tree/bug-fix/preparevalidation-not-called-with-skips-empty-rows

[patrickbrouwers]

@VFAndrew this setPreparationCallback was PR'd by someone else, so I'm not 100% sure, but it seems logical as you suggest. You can PR it.

[VFAndrew]

@VFAndrew this setPreparationCallback was PR'd by someone else, so I'm not 100% sure, but it seems logical as you suggest. You can PR it.

@patrickbrouwers Should I just update this PR with the fix?

[patrickbrouwers]

@VFAndrew yes that is fine!