Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an ability to specify CSV ouput encoding #3507

Merged
merged 4 commits into from
Jan 27, 2022
Merged

Added an ability to specify CSV ouput encoding #3507

merged 4 commits into from
Jan 27, 2022

Conversation

Lupennat
Copy link
Contributor

@Lupennat Lupennat commented Jan 24, 2022

1️⃣ Why should it be added? What are the benefits of this change?
sometimes it is necessary to be able to export a CSV file directly with an encoding different from UTF-8

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests, if possible?
Yes

4️⃣ Any drawbacks? Possible breaking changes?
No, the default is 'UTF-8'

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@patrickbrouwers patrickbrouwers merged commit eb31f30 into SpartnerNL:3.1 Jan 27, 2022
@patrickbrouwers
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants