Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SkipsEmptyRows support with the WithColumnLimit concern #3455

Conversation

fsilvestro
Copy link
Contributor

@fsilvestro fsilvestro commented Dec 3, 2021

In this PR, the WithColumnLimit concern was added.
However the PR didn't take into account the ability to use WithColumnLimit at the same time as the other SkipsEmptyRows concern.
The toArray function of the Sheet class is looping through each row in the worksheet. For every row, if the SkipsEmptyRows concern is implemented, the isEmpty function is checking that the current row is not empty, NOT taking into account the ending column set implementing the WithColumnLimit concern. The result is that the current row is cached; getting it, the column limit is ignored.

1️⃣ Why should it be added? What are the benefits of this change?
The benefit is to give the community the ability to use the WithColumnLimit and SkipsEmptyRows concerns together.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests, if possible?
Yes

4️⃣ Any drawbacks? Possible breaking changes?
No

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@pokono
Copy link

pokono commented Dec 9, 2021

Looks good. 👏

@patrickbrouwers patrickbrouwers merged commit ad981fd into SpartnerNL:3.1 Dec 22, 2021
@patrickbrouwers
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants