Fixed SkipsEmptyRows support with the WithColumnLimit concern #3455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the
WithColumnLimit
concern was added.However the PR didn't take into account the ability to use
WithColumnLimit
at the same time as the otherSkipsEmptyRows
concern.The
toArray
function of theSheet
class is looping through each row in the worksheet. For every row, if theSkipsEmptyRows
concern is implemented, theisEmpty
function is checking that the current row is not empty, NOT taking into account the ending column set implementing theWithColumnLimit
concern. The result is that the current row is cached; getting it, the column limit is ignored.1️⃣ Why should it be added? What are the benefits of this change?
The benefit is to give the community the ability to use the
WithColumnLimit
andSkipsEmptyRows
concerns together.2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No
3️⃣ Does it include tests, if possible?
Yes
4️⃣ Any drawbacks? Possible breaking changes?
No
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌