-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new Chromium 112 --headless=new
flag, graphics stack enable/disable, lots of docs updates
#76
Conversation
deprecates http font downloads
source/index.ts
Outdated
* If true, the graphics stack and webgl is enabled, | ||
* If false, webgl will be disabled. (If false, the swiftshader driver will also not extract) | ||
*/ | ||
static graphicsStackMode: boolean = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that in serverless environments we need to use swiftshader to use CPU only but we are now introducing a new configuration mode which would can disable webgl.
Would it make sense here to have the mode to have type of "swiftshader" | "swiftshader-webgl" | "webgl-disabled"
?
the new option would be to use swiftshader to render webgl content, or ultimately disable webgl completely.
If the intention is to have an actual boolean maybe we can use something like graphicsStackEnabled
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for most users, swiftshader can be disabled and not used at all, it saves at least a full second on my testing for initial extracts. Swiftshader/angle is what powers webgl, so I'm not sure what the difference would be for swiftshader
or swiftshader-webgl
(Maybe my comment was confusing about the swiftshader driver)
Thanks for the comments! |
--headless=new
flag--headless=new
flag, graphics stack enable/disable, lots of docs updates
Breaking changes:
Change to new headless version
Refactor default args, adding many that are default in puppeteer
Non-breaking changes:
Remove node version check and pull regex out into it's own function, fixes #75
Add ability to disable the graphics stack
Add docs on running headfully and running on arm
fixes #63
fixes #69
fixes #38
fixes #55
fixes #42
fixes #28
😃😃😃😃😃😃😃😃😃
More docs, fixes #77
Two new options are available
These need to be set before launching puppeteer