Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflows #92

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Refactor workflows #92

merged 2 commits into from
Apr 21, 2024

Conversation

OlivierJM
Copy link
Member

No description provided.

Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sparked-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2024 1:05pm

@OlivierJM
Copy link
Member Author

@YewoMhango how do we fix this issue

yarn install v1.22.19
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads ssh://git@github.com/YewoMhango/react-pdf-viewer.git
Directory: /Users/olivierjm/sparked-next
Output:
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I replaced it with this "@intelllex/react-pdf": "https://github.com/YewoMhango/react-pdf-viewer.git", but still got the error.

@YewoMhango
Copy link
Collaborator

Oh, okay, I see. For me, I also encountered that error and it somehow got fixed when I ran rm yarn.lock && yarn. I guess we could just publish it as a separate package on NPM to avoid these issues

@OlivierJM
Copy link
Member Author

Oh, okay, I see. For me, I also encountered that error and it somehow got fixed when I ran rm yarn.lock && yarn. I guess we could just publish it as a separate package on NPM to avoid these issues

This fixed the build, we can publish our own package later. I plan to move this repo to the main organization here https://github.com/SparkEdUAB this way it can be together with other repository.

@OlivierJM OlivierJM merged commit 1effb8d into main Apr 21, 2024
7 checks passed
@OlivierJM OlivierJM deleted the update-workflows branch April 21, 2024 13:23
@brianmuks
Copy link
Collaborator

brianmuks commented Apr 21, 2024 via email

@YewoMhango
Copy link
Collaborator

Oh, okay, I see. For me, I also encountered that error and it somehow got fixed when I ran rm yarn.lock && yarn. I guess we could just publish it as a separate package on NPM to avoid these issues

This fixed the build, we can publish our own package later. I plan to move this repo to the main organization here https://github.com/SparkEdUAB this way it can be together with other repository.

Okay, great

@YewoMhango
Copy link
Collaborator

I actually wanted to suggest that we use an Adobe package. It's good I have used it before

That seems like it would be very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants