-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to UI design #54
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @OlivierJM on Vercel. @OlivierJM first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR, we will review it as soon as possible. Your contribution is highly valued.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
It seems there are some errors with build command
|
@OlivierJM I made some changes. Is it still giving build errors? |
It's fixed now. Thank you. |
@brianmuks kindly also help review this |
Well noted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianmuks can you please check if we should merge this already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YewoMhango this pr looks good just address the following:
- All
i18next
keys should be in lowercase - types should follow this format
T_mytype
- Interface should like wise be formatted like so
I_my_interface
I am available to help you fix some build issues.
@brianmuks there were already lots of other existing types which also didn't strictly conform to the format of both a |
But anyway, I've already renamed them |
@brianmuks let's merge this soon and do more tests in prod. |
Alright |
General
Admin
Other pages improved