Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to UI design #54

Merged
merged 23 commits into from
Mar 21, 2024
Merged

Updates to UI design #54

merged 23 commits into from
Mar 21, 2024

Conversation

YewoMhango
Copy link
Collaborator

@YewoMhango YewoMhango commented Mar 12, 2024

General

  • Added dark mode capabilities
  • Transitioning from Ant Design components to Flowbite
  • Added Next.js loading bar for page navigation
  • Improved logo and favicon
  • Ensured all pages are mobile-responsive
  • Overall design improvements and touches

Admin

  • Added "Create" and "Edit" views as modals to the admin pages for easier editing

Other pages improved

  • Landing page
  • Library page
  • Sign-in and Sign-up

Copy link

vercel bot commented Mar 12, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @OlivierJM on Vercel.

@OlivierJM first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR, we will review it as soon as possible. Your contribution is highly valued.

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sparked-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 2:38pm

@OlivierJM
Copy link
Member

It seems there are some errors with build command

[19:48:30] Running build in Washington, D.C., USA (East) – iad1
[19:48:31] Cloning github.com/OlivierJM/sparked-next (Branch: main, Commit: e72b0e7)
[19:48:32] Cloning completed: 655.186ms
[19:48:49] Restored build cache
[19:48:49] Running "vercel build"
[19:48:56] Vercel CLI 33.5.4
[19:48:59] Installing dependencies...
[19:49:00] yarn install v1.22.17
[19:49:00] warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[19:49:00] [1/4] Resolving packages...
[19:49:01] [2/4] Fetching packages...
[19:49:41] [3/4] Linking dependencies...
[19:49:41] warning " > zod-form-data@2.0.2" has unmet peer dependency "zod@>= 3.11.0".
[19:49:41] warning Workspaces can only be enabled in private projects.
[19:49:41] warning Workspaces can only be enabled in private projects.
[19:49:41] warning Workspaces can only be enabled in private projects.
[19:49:41] warning Workspaces can only be enabled in private projects.
[19:50:04] [4/4] Building fresh packages...
[19:50:06] success Saved lockfile.
[19:50:06] Done in 66.72s.
[19:50:07] Detected Next.js version: 13.4.17
[19:50:07] Running "yarn run build"
[19:50:07] yarn run v1.22.17
[19:50:07] $ next build
[19:50:07] - info Creating an optimized production build...
[19:51:20] - info Compiled successfully
[19:51:20] - info Linting and checking validity of types...
[19:51:27] 
[19:51:27] ./src/components/courses/courseListView.tsx
[19:51:27] 33:6  Warning: React Hook useEffect has a missing dependency: 'fetchCourses'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 33:7  Warning: The 0 literal is not a valid dependency because it never changes. You can safely remove it.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] ./src/components/layouts/library/index.tsx
[19:51:27] 60:6  Warning: React Hook useEffect has missing dependencies: 'fetchPrograms' and 'fetchSchools'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] ./src/components/media-content/media-content-list-view.tsx
[19:51:27] 35:6  Warning: React Hook useEffect has a missing dependency: 'fetchMediaContent'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] ./src/components/programs/programListView.tsx
[19:51:27] 33:6  Warning: React Hook useEffect has a missing dependency: 'fetchPrograms'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] ./src/components/school/schoolsListView.tsx
[19:51:27] 36:6  Warning: React Hook useEffect has a missing dependency: 'fetchSchools'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] ./src/components/topic/topics-list-view.tsx
[19:51:27] 34:6  Warning: React Hook useEffect has a missing dependency: 'fetchTopics'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] ./src/components/units/unitListView.tsx
[19:51:27] 35:6  Warning: React Hook useEffect has a missing dependency: 'fetchUnits'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] ./src/components/users/UsersListView.tsx
[19:51:27] 33:6  Warning: React Hook useEffect has a missing dependency: 'fetchUnits'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
[19:51:27] 
[19:51:27] info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
[19:51:38] Failed to compile.
[19:51:38] 
[19:51:38] ./src/components/users/index.tsx:6:43
[19:51:38] Type error: Cannot find name 'TunitFields'.
[19:51:38] 
[19:51:38] �[0m �[90m 4 | �[39m�[36mimport�[39m { �[33mColumnData�[39m } �[36mfrom�[39m �[32m'@components/admin/AdminTable/types'�[39m�[33m;�[39m�[0m
[19:51:38] �[0m �[90m 5 | �[39m�[0m
[19:51:38] �[0m�[31m�[1m>�[22m�[39m�[90m 6 | �[39m�[36mexport�[39m �[36mconst�[39m unitTableColumns�[33m:�[39m �[33mColumnData�[39m�[33m<�[39m�[33mTunitFields�[39m�[33m>�[39m[] �[33m=�[39m [�[0m
[19:51:38] �[0m �[90m   | �[39m                                          �[31m�[1m^�[22m�[39m�[0m
[19:51:38] �[0m �[90m 7 | �[39m  {�[0m
[19:51:38] �[0m �[90m 8 | �[39m    title�[33m:�[39m �[32m'#'�[39m�[33m,�[39m�[0m
[19:51:38] �[0m �[90m 9 | �[39m    dataIndex�[33m:�[39m �[32m'index'�[39m�[33m,�[39m�[0m
[19:51:39] error Command failed with exit code 1.
[19:51:39] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[19:51:39] Error: Command "yarn run build" exited with 1
[19:51:39] 

@OlivierJM
Copy link
Member

image

@YewoMhango
Copy link
Collaborator Author

@OlivierJM I made some changes. Is it still giving build errors?

@OlivierJM
Copy link
Member

@OlivierJM I made some changes. Is it still giving build errors?

It's fixed now. Thank you.

@OlivierJM
Copy link
Member

@brianmuks kindly also help review this

@brianmuks
Copy link
Collaborator

@brianmuks kindly also help review this

Well noted.

Copy link
Member

@OlivierJM OlivierJM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmuks can you please check if we should merge this already.

Copy link
Collaborator

@brianmuks brianmuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YewoMhango this pr looks good just address the following:

  • All i18next keys should be in lowercase
  • types should follow this format T_mytype
  • Interface should like wise be formatted like so I_my_interface

I am available to help you fix some build issues.

@YewoMhango
Copy link
Collaborator Author

@YewoMhango this pr looks good just address the following:

* All `i18next` keys should be in lowercase

* types should follow this format `T_mytype`

* Interface should like wise be formatted  like so `I_my_interface`

I am available to help you fix some build issues.

@brianmuks there were already lots of other existing types which also didn't strictly conform to the format of both a T and an undescore. Should I also edit those right now?

@YewoMhango
Copy link
Collaborator Author

But anyway, I've already renamed them

@OlivierJM
Copy link
Member

@brianmuks let's merge this soon and do more tests in prod.

@brianmuks
Copy link
Collaborator

@brianmuks let's merge this soon and do more tests in prod.

Alright

@YewoMhango YewoMhango changed the title Changes to Admin Pages Updates to UI design Mar 17, 2024
@brianmuks brianmuks self-requested a review March 21, 2024 13:13
@OlivierJM OlivierJM merged commit 6717ceb into SparkEdUAB:main Mar 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants