-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database design #10
Database design #10
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep using npm instead of having both with yarn or if you prefer yarn then we should remove package-lock.json.
Also I don't think animations are necessary I would instead recommend svgs like these https://undraw.co/illustrations
Noted. I will use |
@OlivierJM I have addressed the comments above ! |
Thanks. |
@brianmuks this is error causing 2 actions to fail, to reproduce run |
@OlivierJM/sparked-next ***@***.***> I noticed this
error yesterday. It's now fixed. I resolved it on a new PR
`next-auth-config`. I will merge the two branches .
…On Fri, 8 Sept 2023 at 07:24, Olivier JM Maniraho ***@***.***> wrote:
@brianmuks <https://github.com/brianmuks> this is error causing 2 actions
to fail, to reproduce run yarn build on your local
[image: Screenshot 2023-09-08 at 7 22 02 AM]
<https://user-images.githubusercontent.com/11255454/266509630-0ddeec04-ca7b-4463-b47e-33d4af232506.png>
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCPXPIADQSUQU5QZC2NOS3XZKT2LANCNFSM6AAAAAA4LS5BXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
[image: imuks.org]
Brian Mukuka
[image: https://]about.me/brianmuks
<http://about.me/brianmuks>
|
can you merge it with this branch ? It will be easier. |
Sure
…On Fri, 8 Sept 2023 at 12:19, Olivier JM Maniraho ***@***.***> wrote:
@OlivierJM/sparked-next *@*.***> I noticed this error yesterday. It's now
fixed. I resolved it on a new PR next-auth-config. I will merge the two
branches .
… <#m_8325933852870888566_>
can you merge it with this branch ? It will be easier.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCPXPKHTWYFDUIKMYO5OXTXZLWMTANCNFSM6AAAAAA4LS5BXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
[image: imuks.org]
Brian Mukuka
[image: https://]about.me/brianmuks
<http://about.me/brianmuks>
|
@brianmuks can you merge that branch you mentioned that fixes this issue? |
Yes, I can.
…On Mon, 11 Sept 2023 at 16:00, Olivier JM Maniraho ***@***.***> wrote:
Sure
… <#m_6058710894640378938_>
@brianmuks <https://github.com/brianmuks> can you merge that branch you
mentioned that fixes this issue?
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCPXPPIE55OPTH2P4JFUILXZ4KRTANCNFSM6AAAAAA4LS5BXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
[image: imuks.org]
Brian Mukuka
[image: https://]about.me/brianmuks
<http://about.me/brianmuks>
|
Done !
…On Mon, 11 Sept 2023 at 16:44, Brian Mukuka ***@***.***> wrote:
Yes, I can.
On Mon, 11 Sept 2023 at 16:00, Olivier JM Maniraho <
***@***.***> wrote:
> Sure
> … <#m_6058710894640378938_>
>
> @brianmuks <https://github.com/brianmuks> can you merge that branch you
> mentioned that fixes this issue?
>
> —
> Reply to this email directly, view it on GitHub
> <#10 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABCPXPPIE55OPTH2P4JFUILXZ4KRTANCNFSM6AAAAAA4LS5BXQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
[image: imuks.org]
Brian Mukuka
[image: https://]about.me/brianmuks
<http://about.me/brianmuks>
--
[image: imuks.org]
Brian Mukuka
[image: https://]about.me/brianmuks
<http://about.me/brianmuks>
|
awesome, now all the checks are passing. |
@brianmuks You can merge. |
No description provided.