Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Formart event descriptions properly #254

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

alvyynm
Copy link
Member

@alvyynm alvyynm commented Oct 30, 2024

Have you read the contributing guidelines ?

What is the purpose of your pull request?

  • Bug fix
  • New feature
  • Documentation

Proposed changes

The website currently displays event descriptions as one giant paragraph with centered text as shown below.

before

I've fixed this by adding a formatting utility function that takes the text and splits it into paragraphs using \r\n\r\n as the differentiator. I also format the individual text lines nicely (using \r\nas the separator) with sufficient spacing for easier reading as shown below.

after

Warning

Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines (read the guide below for help).

How to Check and Fix Linting Issues

Run npm run validate. This command will run prettier and eslint checks to ensure linting guidelines are respected.

  • If the command exits with code 0 (build is successful), there are no linting issues.

  • If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.

@alvyynm alvyynm self-assigned this Oct 30, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:40am

@alvyynm alvyynm marked this pull request as ready for review October 30, 2024 10:43
@sonylomo sonylomo merged commit 7229bb6 into Dev Nov 12, 2024
4 checks passed
@sonylomo sonylomo deleted the feature/formart-event-descriptions-properly branch November 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants