-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #197: Redesign shop single item view #207
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've noticed there's a lot of merge conflicts with the Perhaps we can reverse #199 first? I know these will be hectic to resolve for anyone working on the shop and created a branch before the PR. I've tried it and I can't tell what to keep and what to remove (Or could it be a skill issue? 😆). What do you guys think @sonylomo @bridgitkanini @Ase020 |
@alvyynm I've also noticed and tried to resolve the conflict on the Dev. I've seen dust there 😂. We could schedule a meeting and come up with a way on how to handle. @JimmyOty is a good DevOps engineer he could also help us with this. |
@Ase020 😂 I thought it's a skill issue on my end. Well, let's wait and see what other members have to say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💃🏾
Have you read the contributing guidelines ?
What is the purpose of your pull request?
Proposed changes
This PR fixes #197.
It changes the design of a single item view from this 👇:
before-redesign.mp4
To this 👇:
single-item-redesign.mp4
Additionally, I've made some extra improvements:
formatPrice
utility function to display prices in the form2,000
(or200
if < 1000) instead of2000.00
NOTE
dummyCartData
array to use in order to redesign the cart drawer found atsrc/APP/components/shop/CartDrawer.jsx
. I chose this approach to save time because there's an existing bug that prevents items from being added to the cart. We can prioritise bug fixing later.Warning
Please read these points carefully and answer honestly with an
X
into all the boxes. Example : [X]
Before submitting a pull request make sure you have: