Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #197: Redesign shop single item view #207

Merged
merged 44 commits into from
Jul 9, 2024

Conversation

alvyynm
Copy link
Member

@alvyynm alvyynm commented Jun 26, 2024

Have you read the contributing guidelines ?

What is the purpose of your pull request?

  • Bug fix
  • New feature

Proposed changes

This PR fixes #197.

It changes the design of a single item view from this 👇:

before-redesign.mp4

To this 👇:

single-item-redesign.mp4

Additionally, I've made some extra improvements:

  • Fixed several accessibility and SEO performance issues
  • Created a formatPrice utility function to display prices in the form 2,000 (or 200 if < 1000) instead of 2000.00

NOTE

Warning

Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines.

alvyynm added 30 commits June 21, 2024 12:04
@alvyynm alvyynm requested review from sonylomo and Ase020 June 26, 2024 08:53
@alvyynm alvyynm self-assigned this Jun 26, 2024
@alvyynm alvyynm linked an issue Jun 26, 2024 that may be closed by this pull request
2 tasks
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 8:28am

@alvyynm alvyynm marked this pull request as ready for review June 26, 2024 08:54
@alvyynm
Copy link
Member Author

alvyynm commented Jun 26, 2024

I've noticed there's a lot of merge conflicts with the Dev branch. Some changes included in #199 touch the entire shop section of the website. And, as we discussed with @sonylomo on WhatsApp, there's also style issues especially on the homepage.

Perhaps we can reverse #199 first? I know these will be hectic to resolve for anyone working on the shop and created a branch before the PR. I've tried it and I can't tell what to keep and what to remove (Or could it be a skill issue? 😆).

What do you guys think @sonylomo @bridgitkanini @Ase020

@Ase020
Copy link
Collaborator

Ase020 commented Jun 26, 2024

I've noticed there's a lot of merge conflicts with the Dev branch. Some changes included in #199 touch the entire shop section of the website. And, as we discussed with @sonylomo on WhatsApp, there's also style issues especially on the homepage.

Perhaps we can reverse #199 first? I know these will be hectic to resolve for anyone working on the shop and created a branch before the PR. I've tried it and I can't tell what to keep and what to remove (Or could it be a skill issue? 😆).

What do you guys think @sonylomo @bridgitkanini @Ase020

@alvyynm I've also noticed and tried to resolve the conflict on the Dev. I've seen dust there 😂. We could schedule a meeting and come up with a way on how to handle. @JimmyOty is a good DevOps engineer he could also help us with this.

@alvyynm
Copy link
Member Author

alvyynm commented Jun 26, 2024

@Ase020 😂 I thought it's a skill issue on my end. Well, let's wait and see what other members have to say.

sonylomo
sonylomo previously approved these changes Jul 9, 2024
Copy link
Collaborator

@sonylomo sonylomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💃🏾

@sonylomo sonylomo mentioned this pull request Jul 9, 2024
5 tasks
@sonylomo sonylomo merged commit b62f787 into Dev Jul 9, 2024
3 of 4 checks passed
@sonylomo sonylomo deleted the 197-redesign-shop-single-item-view branch July 9, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Shop: Single Item View
3 participants