Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes: Shipyard.shiptyps.type, supply-contruction:201, enum normalizing #80

Conversation

kjackson1998
Copy link
Contributor

@kjackson1998 kjackson1998 commented Nov 18, 2023

Not sure it makes sense to ever have a response to ../shipyard where shipTypes has an element where the type is not provided.

net effect:

image

@kjackson1998 kjackson1998 changed the title Shipyard.shipTypes.type should not be optional. Shipyard.shipTypes.type should not be optional and pull out Nov 19, 2023
@kjackson1998 kjackson1998 changed the title Shipyard.shipTypes.type should not be optional and pull out Shipyard.shipTypes.type should not be optional and pull out WaypointModifierSymbol Nov 19, 2023
@kjackson1998 kjackson1998 changed the title Shipyard.shipTypes.type should not be optional and pull out WaypointModifierSymbol Various fixes: Shipyard.shiptyps.type, supply-contruction:201, enum normalizing Nov 28, 2023
@space-admiral space-admiral self-requested a review December 5, 2023 16:33
Copy link
Contributor

@space-admiral space-admiral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@space-admiral space-admiral merged commit d2663cd into SpaceTradersAPI:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants