Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes cluster hardening standard (previously "K8s cluster baseline security") #581

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

cah-hbaum
Copy link
Contributor

The "Baseline K8s cluster security" was created previously. In the PR (#376) there were some discussions about the structure and overall usefulness of the standard.
This issue should adapt the standard (since it is still in the draft phase) in order to better adhere to the requirements brought forward.
The standard was also retitled to "Kubernetes cluster hardening".

@cah-hbaum cah-hbaum added security Issues or pull requests that are security-relevant Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS-VP10 Related to tender lot SCS-VP10 labels Apr 30, 2024
@cah-hbaum cah-hbaum self-assigned this Apr 30, 2024
@cah-hbaum cah-hbaum added standards Issues / ADR / pull requests relevant for standardization & certification SCS is standardized SCS is standardized labels Apr 30, 2024
@cah-hbaum cah-hbaum force-pushed the issue/475-update-baseline-cluster-security-standard branch 2 times, most recently from 14a726d to 472a80e Compare May 2, 2024 08:27
@cah-hbaum cah-hbaum force-pushed the issue/475-update-baseline-cluster-security-standard branch 2 times, most recently from 2d9145b to cd76a26 Compare May 2, 2024 09:34
@jschoone jschoone self-requested a review May 16, 2024 08:48
Copy link
Contributor

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the clear explanation of concepts before recommending something, but it could be argued that these in depth details should not be part of the standard itself. I myself find it very handy to have the reasoning in the same file as the decisions itself.

I would like to hear more opinions on this, though (I could imagine @mbuechse has something to say about this from a meta-standard perspective?) because I think the standard at least somewhat deviates in this regard from our other standards.

One solution could be to move the explanations into a dedicated file, but we could as well just keep this as-is. I have no strong opinion on this matter myself, I just wanted to mention it because I think other people might have objections in this regard.

The standard looks mostly good to me, I have made some comments regarding wording and some - I think - incomplete sentences need fixing.

Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small typos...

Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
@cah-hbaum cah-hbaum force-pushed the issue/475-update-baseline-cluster-security-standard branch from a2adca5 to 4b431bd Compare May 27, 2024 12:45
@cah-hbaum
Copy link
Contributor Author

Rebased the branch.

Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is impressive. One problem I have is to find what the standard requires of me. There is a lot of recommendations and best practice suggestions. But can we (in principle) make a succinct list of requirements? Could you please work on an MVP for a test? I think tests are very important to make clear what the standard really requires, and whether it's practical.

Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally missed the section "Standard". Okay, so we have a succinct list. I think we can drop the introductory paragraph from that section, but I would add a remark somewhere in the beginning of the "Hardening Kubernetes" paragraph that "Hardening Kubernetes" is not authoritative, and that the "Standards" section contains the authoritative part.

@bitkeks bitkeks self-requested a review June 13, 2024 12:26
@cah-hbaum cah-hbaum force-pushed the issue/475-update-baseline-cluster-security-standard branch from 4b431bd to b602e3a Compare June 17, 2024 09:36
@cah-hbaum
Copy link
Contributor Author

Sorry, I totally missed the section "Standard". Okay, so we have a succinct list. I think we can drop the introductory
paragraph from that section, but I would add a remark somewhere in the beginning of the "Hardening Kubernetes"
paragraph that "Hardening Kubernetes" is not authoritative, and that the "Standards" section contains the authoritative part.

Updated the paragraphs just as mentioned by @mbuechse
Also did some rebasing to remove the merge conflicts

Update baseline cluster security

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
@cah-hbaum cah-hbaum force-pushed the issue/475-update-baseline-cluster-security-standard branch from b602e3a to b44a0ee Compare June 17, 2024 12:18
Copy link
Member

@bitkeks bitkeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm approving the draft because it's good work and covers a lot of aspects. The standard paragraph makes sense to me.

Of course these kind of guides always have room for debates around scope and requirements. Does not mean I object to other people's inputs and improvement suggestions 😉

Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Show resolved Hide resolved
Standards/scs-0217-v1-cluster-hardening.md Outdated Show resolved Hide resolved
bitkeks and others added 4 commits June 21, 2024 12:08
Made a small adjustment to read-only port section in order to address some mentions by @bitkeks.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
Made a small adjustment to related documents in order to address some mentions by @bitkeks.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
@mbuechse
Copy link
Contributor

This is ready to merge. I trust that you did what you said. So I won't review it now. You can proceed.

@cah-hbaum
Copy link
Contributor Author

Merging!

@cah-hbaum cah-hbaum merged commit f16e4e8 into main Jun 25, 2024
5 checks passed
@cah-hbaum cah-hbaum deleted the issue/475-update-baseline-cluster-security-standard branch June 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 security Issues or pull requests that are security-relevant standards Issues / ADR / pull requests relevant for standardization & certification
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Standard "Baseline K8s Cluster Security" - rename to "K8s cluster hardening"
5 participants