Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test for flavor-name syntax in scs-0103 yaml file #438

Merged
merged 6 commits into from
Jan 11, 2024
Merged

CI test for flavor-name syntax in scs-0103 yaml file #438

merged 6 commits into from
Jan 11, 2024

Conversation

mbuechse
Copy link
Contributor

closes #339

Test it like so:

$ Tests/iaas/flavor-naming/check-yaml.py Tests/testing/
ERROR: flavor 'SCS-1V-4': field 'cpu-type' contradicting name-v2 'SCS-1V-4'; found 'crowded-core', expected 'shared-core'
ERROR: flavor 'SCS-2V-8': field 'name-v1' contradicting name-v2 'SCS-2V-8'; found 'SCS-2V-8', expected 'SCS-2V:8'
ERROR: flavor 'SCS-4V-16': field 'ram' contradicting name-v2 'SCS-4V-16'; found '12', expected '16.0'
ERROR: flavor 'SCS-1V-2': field 'cpus' contradicting name-v2 'SCS-1V-2'; found '2', expected '1'
ERROR: flavor 'SCS-2V-4-20s': field 'disk0-type' contradicting name-v2 'SCS-2V-4-20s'; found 'network', expected 'ssd'
ERROR: flavor 'SCS-4V-16-100s': field 'disk' contradicting name-v2 'SCS-4V-16-100s'; found '10', expected '100'
ERROR: file 'scs-0103-v1-flavors-wrong.yaml': found 6 errors

@mbuechse
CI test for flavor-name syntax in scs-0103 yaml file
a19dd4b 
closes #339

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse
Pacify flake8 (which found a real mistake)
b2bf114 
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse
Document testing file, add case of spurious disk
5565ec4 
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse
Improve robustness
c7655a9 
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@berendt berendt self-requested a review January 10, 2024 09:55
artificial-intelligence
artificial-intelligence reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside some nits and opinions surrounding naming and documenting stuff.

Tests/iaas/flavor-naming/check-yaml.py Show resolved Hide resolved
Tests/iaas/flavor-naming/check-yaml.py Outdated Show resolved Hide resolved
Tests/iaas/flavor-naming/check-yaml.py Show resolved Hide resolved
Tests/iaas/flavor-naming/check-yaml.py Outdated Show resolved Hide resolved
@mbuechse
Improved documentation/naming according to the review by @artificial-…
26c8ca8 
…intelligence

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse
Fixed error message
c70231f 
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
artificial-intelligence
artificial-intelligence approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbuechse mbuechse merged commit ea173de into main Jan 11, 2024
4 checks passed
@mbuechse mbuechse deleted the issue/339 branch January 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artificial-intelligence artificial-intelligence artificial-intelligence approved these changes

@garloff garloff Awaiting requested review from garloff

@fkr fkr Awaiting requested review from fkr

@berendt berendt Awaiting requested review from berendt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI tests for mandatory-flavor-list (#319)
2 participants
@mbuechse @artificial-intelligence