Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standardization] K8s cluster robustness features (#414) #361

Merged
merged 9 commits into from
Feb 1, 2024
Merged

[Standardization] K8s cluster robustness features (#414) #361

merged 9 commits into from
Feb 1, 2024

Conversation

cah-hbaum
Copy link
Contributor

@cah-hbaum cah-hbaum commented Oct 17, 2023 •
edited
Loading

This commit adds the standard for K8s robustness features, including Kube-API rate limiting, ETCD compaction as well as CA expiration avoidance.

Closes SovereignCloudStack/issues#414

@cah-hbaum cah-hbaum added Container Issues or pull requests relevant for Team 2: Container Infra and Tooling standards Issues / ADR / pull requests relevant for standardization & certification SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 SCS is opinionated SCS has the courage to take decisions in its implementation choices to provide a clear focus labels Oct 17, 2023
@cah-hbaum cah-hbaum self-assigned this Oct 17, 2023
@cah-hbaum cah-hbaum linked an issue Oct 17, 2023 that may be closed by this pull request
[Standardization] KaaS Robustness features SovereignCloudStack/issues#414
Closed
2 tasks
@cah-hbaum cah-hbaum force-pushed the issue/414 branch 4 times, most recently from 676e1dc to 3b82bb6 Compare October 18, 2023 07:28
joshmue
joshmue reviewed Oct 23, 2023
View reviewed changes
Standards/scs-0215-v1-robustness-features.md Outdated Show resolved Hide resolved
Standards/scs-0215-v1-robustness-features.md Outdated Show resolved Hide resolved
Standards/scs-0215-v1-robustness-features.md Outdated Show resolved Hide resolved
@cah-hbaum cah-hbaum force-pushed the issue/414 branch 2 times, most recently from d59e09d to 803e5a3 Compare November 6, 2023 10:35
matofeder
matofeder approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@matofeder matofeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cah-hbaum cah-hbaum force-pushed the issue/414 branch 3 times, most recently from d8b01ba to e6583e9 Compare November 9, 2023 09:12
@anjastrunk anjastrunk self-requested a review November 9, 2023 12:35
@anjastrunk
Copy link
Contributor

There are three open threads left. After they are solved, I will give my approval.

@cah-hbaum cah-hbaum changed the title K8s cluster robustness features (#414) [Standardization] K8s cluster robustness features (#414) Dec 7, 2023
@cah-hbaum
Copy link
Contributor Author

Updated the standard and (hopefully) fixed all the problems mentioned.

@jschoone
Copy link
Contributor

jschoone commented Dec 8, 2023

@SovereignCloudStack/vp05 please review as we want to achieve the standards in our reference implementation

anjastrunk
anjastrunk approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@anjastrunk anjastrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cah-hbaum cah-hbaum force-pushed the issue/414 branch 2 times, most recently from 9521be7 to 923bfe6 Compare December 19, 2023 12:00
@cah-hbaum
K8s cluster robustness features (#414)
67a1d8e 
This commit adds the standard for K8s robustness features, including Kube-API rate limiting, ETCD compaction as well as CA expiration avoidance.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
matofeder
matofeder approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@matofeder matofeder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I've read this updated version again, and I like this format, i.e. I as a consumer of SCS standard I can see what exactly I should do to have an "SCS-compatible" k8s cluster 👍

@jschoone jschoone self-requested a review January 11, 2024 09:43
@cah-hbaum
fixup! K8s cluster robustness features (#414)
84fcef3 
Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
@cah-hbaum
fixup! K8s cluster robustness features (#414)
f846ba3 
Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
cah-hbaum and others added 5 commits January 12, 2024 14:36
@cah-hbaum
fixup! K8s cluster robustness features (#414)
e2469bb 
Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
@cah-hbaum
fixup! K8s cluster robustness features (#414)
3eb4898 
Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
@jschoone
chore(wording): recommend to use the long form for this type of document
ef6ad56 
Signed-off-by: Jan Schoone <jan@jass.es>
@cah-hbaum
fixup! K8s cluster robustness features (#414)
b9aa12d 
Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
@cah-hbaum
fixup! K8s cluster robustness features (#414)
b9b4c9a 
Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
@jschoone jschoone merged commit 863ac32 into main Feb 1, 2024
5 checks passed
@jschoone jschoone deleted the issue/414 branch February 1, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmue joshmue joshmue left review comments

@jschoone jschoone jschoone approved these changes

@matofeder matofeder matofeder approved these changes

@anjastrunk anjastrunk anjastrunk approved these changes

Assignees

@cah-hbaum cah-hbaum

Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS is opinionated SCS has the courage to take decisions in its implementation choices to provide a clear focus SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 standards Issues / ADR / pull requests relevant for standardization & certification
Projects
Sovereign Cloud Stack
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Standardization] KaaS Robustness features
5 participants
@cah-hbaum @anjastrunk @jschoone @matofeder @joshmue