remove nft-utils and move the code into sov-nft-module and demo-rollup #992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the location and structure of the
sov-nft-module
interaction code.Context:
Previously, the code to interact with the
sov-nft-module
was located in a separate top-level project namedutils/nft-utils
. This arrangement was chosen because this code depended on the Runtime for encoding the enum variant of calls and transaction creation.Problem:
Having
nft-utils
at the top level creates a compilation issue if someone decides to remove thesov-nft-module
.Proposed Solution:
This PR proposes a better organized solution:
utils.rs
inside thesov-nft-module
.demo-rollup/src/bin/sov-nft-script.rs
. This binary will leverage the utilities fromsov-nft-module
and handle transaction construction.nft-utils
has been completely removed.