Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rollup template #979

Merged
merged 30 commits into from
Oct 11, 2023
Merged

Create rollup template #979

merged 30 commits into from
Oct 11, 2023

Conversation

preston-evans98
Copy link
Member

Description

This PR implements a basic rollup template, which combines an STF and the "full-node" implementation into a single package. A follow-up will add the following missing functionality:

  • Working CLI
  • Prover/verifier logic

Testing

One end-to-end test has been added. Additional test coverage will be added in follow-ups.

@preston-evans98 preston-evans98 changed the title Preston/rollup template Create rollup template Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #979 (a703fcd) into nightly (5fff4f8) will decrease coverage by 0.4%.
The diff coverage is 60.0%.

❗ Current head a703fcd differs from pull request most recent head d5dbc42. Consider uploading reports for the commit d5dbc42 to get more accurate results

Files Coverage Δ
full-node/sov-stf-runner/src/config.rs 100.0% <100.0%> (ø)
full-node/sov-stf-runner/src/lib.rs 100.0% <100.0%> (ø)
rollup-interface/src/state_machine/mocks/da.rs 82.4% <ø> (ø)
templates/rollup-template/src/rollup/rpc.rs 100.0% <100.0%> (ø)
templates/rollup-template/src/stf/builder.rs 100.0% <100.0%> (ø)
templates/rollup-template/src/bin/cli_wallet.rs 0.0% <0.0%> (ø)
templates/rollup-template/src/rollup/mod.rs 89.5% <89.5%> (ø)
templates/rollup-template/src/da.rs 0.0% <0.0%> (ø)
templates/rollup-template/src/bin/verifier.rs 0.0% <0.0%> (ø)
templates/rollup-template/src/stf/runtime.rs 65.0% <65.0%> (ø)
... and 3 more

... and 3 files with indirect coverage changes

Copy link
Member

@cemozerr cemozerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great. I'll leave it to someone more day-to-day in the codebase to leave a complete review with an approve.

examples/demo-stf/src/hooks_impl.rs Outdated Show resolved Hide resolved
templates/rollup-template/rollup_config.toml Outdated Show resolved Hide resolved
templates/rollup-template/src/builder.rs Outdated Show resolved Hide resolved
templates/rollup-template/src/builder.rs Outdated Show resolved Hide resolved
@bkolad bkolad enabled auto-merge October 11, 2023 11:59
@bkolad bkolad added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2023
@bkolad bkolad added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2023
@bkolad bkolad enabled auto-merge October 11, 2023 17:29
@bkolad bkolad added this pull request to the merge queue Oct 11, 2023
Merged via the queue into nightly with commit 61a44bf Oct 11, 2023
@bkolad bkolad deleted the preston/rollup-template branch October 11, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants