-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Storage::backing
method
#978
Conversation
module-system/module-implementations/sov-attester-incentives/src/query.rs
Show resolved
Hide resolved
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need the get_bond_proof
method for optimistic rollups (and in other places), so I would definitely prefer not to remove it. If we don't remove it, what options do we have to unblock you?
0be8bd6
to
f6e95db
Compare
Description
As it heavily leaks abstraction.
Replace it with
fn get_with_proof(&self, key: StorageKey) -> Option<StorageProof<Self::Proof>>
which at least does not expose underlying storage.Testing
Current tests are passing
Docs
No updates in documentation