Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Implement chainId #886

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Conversation

orkunkilic
Copy link
Contributor

Description

Returns the chain id from EVM config

Linked Issues

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #886 (9609233) into nightly (118f196) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Files Changed Coverage Δ
...system/module-implementations/sov-evm/src/query.rs 0.0% <0.0%> (ø)

@orkunkilic orkunkilic requested a review from bkolad September 18, 2023 09:12
Copy link
Member

@bkolad bkolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CI is not happy because of code formatting. make lint-fix command will fix it.

@bkolad bkolad added this pull request to the merge queue Sep 18, 2023
Merged via the queue into Sovereign-Labs:nightly with commit 684b708 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM: Implement eth_chainId endpoint.
2 participants