EVM: Implement getBlockByNumber query #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
LukaszRozmej
previously requested changes
Sep 15, 2023
orkunkilic
changed the title
|
Tests are added, I think good to go after final review. |
bkolad
approved these changes
Sep 19, 2023
| .expect("Transaction must be set"); | ||
| (id, tx) | ||
| }) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
You shouldn't need to collect it here, this causes unnecessary allocation on heap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements get_block_by_number method in sov-evm query. Implemented "earliest", "latest", and hex parameters. Implemented both details(full / hash) on transaction return type.
Block_number defaults to latest block if not present.
Looking forward for efficiency feedbacks!
Linked Issues
eth_getBlockByNumberendpoint. #878Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Tests WIP
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?
No docs added yet.