feat: update sovereign.toml resoultion to relative path #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the resolution of the sovereign.toml dependend on unstable features of proc-macro2, available only for recent toolchain versions. This commit introduces the path resolution of the manifest file to recurse from the target directory. It will allow endpoints to set their own manifest file, replacing the ones bundled with the modules. It will also read an optional `SOVEREIGN_MANIFEST` that, if set, will override the manifest path. The manifest path is expected to be resolved at compile time, making it possible to construct const/static structures with it.
Codecov Report
|
preston-evans98
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the resolution of the sovereign.toml depended on unstable features of proc-macro2, available only for recent toolchain versions.
This commit introduces the path resolution of the manifest file to recurse from the target directory. It will allow endpoints to set their own manifest file, replacing the ones bundled with the modules.
It will also read an optional
SOVEREIGN_MANIFESTthat, if set, will override the manifest path. The manifest path is expected to be resolved at compile time, making it possible to construct const/static structures with it.Closes #786