Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused StateDB::update_db method #1074

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Remove unused StateDB::update_db method #1074

merged 1 commit into from
Oct 19, 2023

Conversation

citizen-stig
Copy link
Member

Description

StateDB might need to get support of snapshots, so simplifying public interface helps to achieve this goal.

@citizen-stig citizen-stig requested a review from neysofu October 19, 2023 09:43
@citizen-stig citizen-stig self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1074 (7cf979f) into nightly (e75f8cf) will increase coverage by 0.0%.
Report is 4 commits behind head on nightly.
The diff coverage is 50.0%.

Files Coverage Δ
full-node/db/sov-db/src/state_db.rs 95.0% <50.0%> (+4.4%) ⬆️

... and 4 files with indirect coverage changes

@citizen-stig citizen-stig added this pull request to the merge queue Oct 19, 2023
Merged via the queue into nightly with commit 02abfe9 Oct 19, 2023
13 checks passed
@citizen-stig citizen-stig deleted the nikolai/sov_db_cleanup branch October 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neysofu neysofu neysofu approved these changes

Assignees

@citizen-stig citizen-stig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@citizen-stig @neysofu