Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blob deferral period configurable #1060

Merged
merged 19 commits into from
Oct 17, 2023
Merged

Conversation

preston-evans98
Copy link
Member

@preston-evans98 preston-evans98 commented Oct 17, 2023

Description

This PR allows makes the deferral period for blobs (DEFERRED_SLOTS_COUNT) configurable. While the change itself is very simple (1 line), fixing the tests required some more major modifications, because the old tests were predicated on a hard-coded delay period.

During this work, we:

  1. Factor out initialization logic from the tests into a Runtime struct
  2. Create a new BlobWithAppearance struct to track when a blob was posted on the (mock) DA layer and when it should be processed
  3. Update existing tests to work with any DEFERRED_SLOTS_COUNT.
  4. Remove the test deferred_blobs_are_first_after_preferred_sequencer_exit, since the invariant it enforced is not critical, and can no longer be provided when the DEFERRED_SLOTS_COUNT is not exactly equal to 1.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1060 (747e43f) into nightly (606d7b8) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Files Coverage Δ
...module-implementations/sov-blob-storage/src/lib.rs 97.5% <ø> (ø)
module-system/sov-modules-macros/src/manifest.rs 62.6% <ø> (-3.4%) ⬇️
module-system/sov-modules-api/src/lib.rs 89.5% <0.0%> (-1.8%) ⬇️
rollup-interface/src/state_machine/mocks/da.rs 81.1% <0.0%> (-1.3%) ⬇️

... and 2 files with indirect coverage changes

@preston-evans98 preston-evans98 added this pull request to the merge queue Oct 17, 2023
Merged via the queue into nightly with commit 9eb9f72 Oct 17, 2023
13 checks passed
@preston-evans98 preston-evans98 deleted the preston/fix-seq-tests branch October 17, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants