Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RollupTemplate trait and reimplemnt demo-rollup. #1055

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Oct 17, 2023

Description

This PR introduces the RollupTemplate trait. This implementer of this trait has to define all the dependencies needed to create a new rollup and getscreate_new_rollup method for "free" .

Changes:

  1. MockDa & CelestiaDa rollups in demo-rollup are re-implemented in terms of RollupTemplate.
  2. App structure removed form demo-rollup/stf/

sov-rollup-starter will be updated in the next PR.

Testing

CI passes.

Docs

Relevant docs added.

@codecov
Copy link

codecov bot commented Oct 18, 2023

@bkolad bkolad force-pushed the blaze/add_rollup_template branch from 99080d2 to 349d09a Compare October 19, 2023 15:24
@bkolad bkolad requested a review from dubbelosix October 19, 2023 15:31
@bkolad bkolad changed the title WIP: demo-rollup refactoring Adds RollupTemplate and demo-rollup refactoring. Oct 19, 2023
@bkolad bkolad changed the title Adds RollupTemplate and demo-rollup refactoring. Add RollupTemplate trait and reimplemnt demo-rollup. Oct 19, 2023
@bkolad bkolad marked this pull request as ready for review October 19, 2023 15:39
@bkolad bkolad enabled auto-merge October 19, 2023 15:48
@bkolad bkolad added this pull request to the merge queue Oct 19, 2023
Merged via the queue into nightly with commit b28fae0 Oct 19, 2023
14 checks passed
@bkolad bkolad deleted the blaze/add_rollup_template branch October 19, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants