Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split rng_xfers into its own crate #1042

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Split rng_xfers into its own crate #1042

merged 5 commits into from
Oct 17, 2023

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Oct 16, 2023 •
edited
Loading

Description

I'm splitting off rng_xfers into its own utility crate, to facilitate code reuse with the block explorer.

Testing

I'm mostly relying on existing tests, which covert pretty much all of this logic.

@neysofu
Split rng_xfers into its own crate
16dc1e5 
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
@neysofu neysofu enabled auto-merge October 16, 2023 13:25
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #1042 (2cad648) into nightly (cf7ba11) will increase coverage by 0.1%.
Report is 10 commits behind head on nightly.
The diff coverage is 24.1%.

Files Coverage Δ
utils/rng-da-service/src/lib.rs 13.9% <24.1%> (ø)

... and 18 files with indirect coverage changes

@neysofu
Fix dependencies' features
475dc32 
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
@neysofu neysofu disabled auto-merge October 17, 2023 09:54
@neysofu
Fix conversion
4073074
@neysofu
Another fix
729d75d 
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
vlopes11
vlopes11 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I pointed one question. But since it isn't introduced in this PR, we can merge as it is and maybe address the question @ future

utils/rng-da-service/src/lib.rs Show resolved Hide resolved
utils/rng-da-service/src/lib.rs Show resolved Hide resolved
@neysofu neysofu added this pull request to the merge queue Oct 17, 2023
@neysofu neysofu removed this pull request from the merge queue due to a manual request Oct 17, 2023
@neysofu neysofu enabled auto-merge October 17, 2023 15:40
@neysofu neysofu added this pull request to the merge queue Oct 17, 2023
Merged via the queue into nightly with commit 27ae049 Oct 17, 2023
13 checks passed
@neysofu neysofu deleted the filippo/rng-da-service branch October 17, 2023 16:54
@neysofu neysofu mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlopes11 vlopes11 vlopes11 approved these changes

@citizen-stig citizen-stig citizen-stig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neysofu @citizen-stig @vlopes11