Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module-system readme with JsonSchema derivation for CallMessage #1013

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Update module-system readme with JsonSchema derivation for CallMessage #1013

merged 5 commits into from
Oct 10, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Oct 10, 2023 •
edited
Loading

Description

Added a section in module-system/Readme to explain why we need schemars(bound = ??) in CallMessage

Testing

No changes.

Docs

Docs updated.

@bkolad bkolad changed the title Update module-system readme Update module-system readme with JsonSchema derivation for CallMessage Oct 10, 2023
@bkolad bkolad requested a review from citizen-stig October 10, 2023 12:26
@bkolad bkolad marked this pull request as ready for review October 10, 2023 12:26
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1013 (94a0703) into nightly (a11bf76) will increase coverage by 0.0%.
The diff coverage is n/a.

see 1 file with indirect coverage changes

@bkolad bkolad enabled auto-merge October 10, 2023 12:52
@bkolad bkolad added this pull request to the merge queue Oct 10, 2023
Merged via the queue into nightly with commit 714bb96 Oct 10, 2023
@bkolad bkolad deleted the blaze/serde_bounds_readme branch October 10, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen-stig citizen-stig citizen-stig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkolad @citizen-stig